feat: redis not mandatory #394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilu
requested changes
Sep 25, 2025
Contributor
There was a problem hiding this comment.
@delcroip If USE_CACHE = True but redis is not up then it's a config error; suppressing it would violate the "fail fast" rule. I'd suggest instead check in settings and raise with a meaningful message if USE_CACHE = True and redis is not reachable, so the app wouldn't even start if it's misconfigured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was testing I got a connection error because the redis server that was configured was not up, therefore I added that to avoid blocking the app in such case