Fix/pyminizip mac incompatibility issue #60
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding missing rights
…patibility on Mac device
weilu
reviewed
Oct 31, 2025
| ) | ||
| with zipfile.ZipFile(zip_file.name, 'w', zipfile.ZIP_DEFLATED) as zf: | ||
| zf.setpassword(bytes(ToolsConfig.get_master_data_password(), 'utf-8')) | ||
| zf.write(master_data_file_path, os.path.basename(master_data_file_path)) |
There was a problem hiding this comment.
Would be good to add a unit test to cover this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve the issue of pyminizip compilation error on Mac M series machines using python 3.11. Detail of the issue is attached here: Compilation Error with Pyminizip
As pyminizip was only used in one function and there is a python default package called zipfile, which also provides the same functionality, we can resolve this issue by replacing the pyminizip package with zipfile, which will also reduce external dependency.