Skip to content

OP-2795: show message no options in pricelistPickers when they have none #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Blue-B-code wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

OP-2795: show message no options in pricelistPickers when they have none #293

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b61ef86
show message no options in pricelistPickers when they have none
Blue-B-code Nov 17, 2025
8d8d9ca
corrections
Blue-B-code Nov 18, 2025
6baae36
corrections
Blue-B-code Nov 19, 2025
69e0883
corrections
Blue-B-code Nov 20, 2025
f9bf8af
corrections
Blue-B-code Nov 20, 2025
f922360
corrections
Blue-B-code Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/components/inputs/SelectInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ class SelectInput extends Component {
if (!!readOnly) {
valueStr = options.filter((o) => JSON.stringify(o.value) === JSON.stringify(value)).map((o) => o.label);
}
const moduleProp = this.props.intl.messages[`${module}.pickerNoOptionsLabel`] ? module : "core";
console.log("moduleProp", moduleProp);
console.log("module", module);
return (
<Fragment>
{!readOnly && (
Expand All @@ -90,25 +93,33 @@ class SelectInput extends Component {
id: `${_.uuid()}-input`,
title: title,
}}
value={!!value ? JSON.stringify(value) : null}
value={!!value ? JSON.stringify(value) : ""}
onChange={this._onChange}
IconComponent={this.renderIconComponent()}
disabled={disabled}
endAdornment={this.renderEndAdornment()}
displayEmpty
//NOTE: We want to get rid of default styling (marginTop) if label is not rendered
{...(withLabel ? null : { style: { marginTop: "0px" } })}
>
{placeholder && (
<MenuItem disabled value="">
<FormattedMessage module={module} id={placeholder} />
</MenuItem>
)}
{options.map((option, idx) => (
<MenuItem key={`${module}-${name}-option-${idx}`} value={JSON.stringify(option.value)}>
{option.label}

{options.length === 0 && (
<MenuItem disabled key={`${module}-${name}-option-0`}>
<FormattedMessage module={moduleProp} id="pickerNoOptionsLabel" />
</MenuItem>
))}
)}

{options.length > 0 &&
options.map((option, idx) => (
<MenuItem key={`${module}-${name}-option-${idx}`} value={JSON.stringify(option.value)}>
{option.label}
</MenuItem>
))
}
</Select>
</FormControl>
)}
Expand Down
1 change: 1 addition & 0 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"core.pickerNoOptionsLabel": "No options available",
"core.roleManagement.label": "Roles Management",
"core.roleManagement.searcher.results.title": "{rolesTotalCount} Roles Found",
"core.roleManagement.roleName": "Role Name",
Expand Down