8333146: Move maven publication logic from build.gradle

[Maran23]

This PR splits the maven publishing logic into an own file, maven-publish.gradle, that is next to the root build.gradle.

The build.gradle will apply the maven-publish.gradle. The maven-publish.gradle will then configure the Maven related properties and register all modules for publication.

This way, we decoupled the logic that much, the only things we need to do:

• apply from maven-publish.gradle
• Call configureMavenPublication later in the build chain.

To better understand the context, this is the commit where the whole Maven Publishing logic was introduced. I moved all of that logic out of the main build.gradle: 5a18677

This will reduce the size by ~170 lines for the build.gradle.

Tested with:

• ./gradlew -PMAVEN_PUBLISH=true -PMAVEN_VERSION=custom publishToMavenLocal
• ./gradlew -PMAVEN_PUBLISH=true publishToMavenLocal
• ./gradlew -PMAVEN_PUBLISH=true -PMILESTONE_FCS=true publishToMavenLocal

Everything still works:
-> Example: javafx.base from the local .m2 repository

I think this is a good step and an easy way to split out functionality without blowing things up. We might want to do that for other parts as well.

Note: I also fixed the deprecated buildDir, the deprecated project.task method and 2 warnings where it seems like he might not be able to infer the type (changing def to the actual type).
-> The file is completely green, no warnings or deprecations.
Note2: I did a small improvement to the addMavenPublication method. It is now more 'typesafe', e.g. projects must be passed in directly, not as String. If a project does not exist, the build will fail with an exception.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8333146: Move maven publication logic from build.gradle (Enhancement - P4)

Reviewers

• Joeri Sykora (@tiainen - Author) 🔄 Re-review required (review applies to 1af96337)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1970/head:pull/1970
$ git checkout pull/1970

Update a local copy of the PR:
$ git checkout pull/1970
$ git pull https://git.openjdk.org/jfx.git pull/1970/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1970

View PR using the GUI difftool:
$ git pr show -t 1970

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1970.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 03: Full - Incremental (ea0b427c)
• 02: Full - Incremental (b465f5e0)
• 01: Full - Incremental (2b45aa63)
• 00: Full (1af96337)

[kevinrushforth]

Reviewers: @johanvos @tiainen and one of @kevinrushforth or @arapte

/reviewers 2 reviewers

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[nlisker]

Note that there's a relevant stale PR in #1232 by @jjohannes. Maybe he'd like to take a look.

[Maran23]

Note that there's a relevant stale PR in #1232 by @jjohannes. Maybe he'd like to take a look.

Thanks. It looks like my work will not block/interfere the implementation of that PR, which is good.
It should be easy to pick the changes from there over in the new maven-publish.gradle.
Should also help for reviewing, since it is more isolated. :-)

[jjohannes]

Thanks for the ping. I have to rework my PR anyway. There is no need to pay special attention to it. Any change that makes the publishing setup clearer is good IMO. I think this PR is a good step forward.

(I didn't get back to the topic yet on the my PR, because it is more work as I initially expected. What is complicating things me there is how conceptually get the setup right with the Jars for different platform built on different machines. I have to set aside some mote time for it.)

[Maran23]

I found a way to further decouple the maven publishing logic!

Now we only need to: apply from: 'maven-publish.gradle' after all projects were defined. Later in the build chain, we need to call the configureMavenPublication Closure from 'maven-publish.gradle', and we are done.

It will work like before, so there is no logical change. But still need a re-review. I retested all configurations.