Skip to content

8356770: TreeTableView not updated after removing a TreeItem with children and adding it to another parent #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+61 −1
Open

8356770: TreeTableView not updated after removing a TreeItem with children and adding it to another parent #1971

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13d8b77
Added new treeStructureDirty
Ziad-Mid Nov 12, 2025
4a07d87
Add test
Ziad-Mid Nov 13, 2025
58f9f4e
Minor test changes
Ziad-Mid Nov 14, 2025
e160a15
minor change
Ziad-Mid Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableViewSkin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class TreeTableViewSkin<T> extends TableViewSkinBase<T, TreeItem<T>, Tree
ObjectProperty<ObservableList<TreeItem<T>>> tableBackingListProperty;
private final TreeTableViewBehavior<T> behavior;
private final EventHandler<TreeItem.TreeModificationEvent<T>> rootListener;

private boolean treeStructureDirty;


/* *************************************************************************
Expand Down Expand Up @@ -147,6 +147,12 @@ public TreeTableViewSkin(final TreeTableView<T> control) {
control.requestLayout();
break;
}
else if (eventType.equals(TreeItem.<T>childrenModificationEvent())) {
Copy link
Member

@Maran23 Maran23 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: else if should be in the previous line to follow the Java Code Convention: } else if (..)

markItemCountDirty();
treeStructureDirty = true;
control.requestLayout();
break;
}
eventType = eventType.getSuperType();
}
}
Expand Down Expand Up @@ -347,6 +353,10 @@ private TreeTableRow<T> createCell() {
// A unit test exists in TreeTableViewTest to ensure that
// the performance issue covered in JDK-8147483 doesn't regress.
// requestRebuildCells();
treeStructureDirty = false;
} else if (treeStructureDirty) {
requestRebuildCells();
treeStructureDirty = false;
} else {
needCellsReconfigured = true;
}
Expand Down