-
Notifications
You must be signed in to change notification settings - Fork 64
Fix ConfigurationCache #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thorsten <[email protected]>
|
@abhinayagarwal Who would be the appropriate person to look at this PR? |
|
@samypr100 @jperedadnr could one of you help with getting someone to merge this and do a patch release? |
|
This PR is causing 2 tests to fail: |
|
Ok I will have a look |
Signed-off-by: Thorsten <[email protected]>
|
Tests fail because these changes break compatibility with the modularity plugin. This seems to be quite the mess to fix. |
Signed-off-by: Thorsten <[email protected]>
|
So I got it mostly running again. |
|
Moving minimum version to 6.4 does sound like a viable solution. |
|
pr is ready |
|
Hi, I have fixed the build failure in #176. Can you please update your branch with latest changes from |
Fix for #136 -> lets fix the configuration cache