Skip to content

Conversation

@tg-freigmbh
Copy link
Contributor

Fix for #136 -> lets fix the configuration cache

Signed-off-by: Thorsten <[email protected]>
@zellyn
Copy link

zellyn commented Mar 12, 2025

@abhinayagarwal Who would be the appropriate person to look at this PR?

@jjohannes
Copy link
Contributor

@samypr100 @jperedadnr could one of you help with getting someone to merge this and do a patch release?

@abhinayagarwal
Copy link
Collaborator

This PR is causing 2 tests to fail:

JavaFXPluginSmokeTestGradle76 > smokeTestModularWithModularityPlugin() FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at DefaultGradleRunner.java:269

JavaFXPluginSmokeTestGradle83 > smokeTestModularWithModularityPlugin() FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at DefaultGradleRunner.java:269

25 tests completed, 2 failed

@tg-freigmbh
Copy link
Contributor Author

Ok I will have a look

@tg-freigmbh
Copy link
Contributor Author

Tests fail because these changes break compatibility with the modularity plugin. This seems to be quite the mess to fix.
Also Something different has changed for when testing against the current gradle version 8.14..

@tg-freigmbh
Copy link
Contributor Author

tg-freigmbh commented May 15, 2025

So I got it mostly running again.
There is one setup that is still broken: 6.1<= gradle version < 6.4 + moduleoptions plugin.
I would suggest dropping support for gradle 6.1 and require minmun 6.4 if thats ok with you?

@abhinayagarwal
Copy link
Collaborator

Moving minimum version to 6.4 does sound like a viable solution.

@tg-freigmbh
Copy link
Contributor Author

pr is ready

@abhinayagarwal
Copy link
Collaborator

Hi,

I have fixed the build failure in #176. Can you please update your branch with latest changes from master branch?

@abhinayagarwal abhinayagarwal merged commit 9f43de5 into openjfx:master May 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants