Skip to content

Conversation

@GautamBytes
Copy link
Contributor

This PR adds unit tests for the errSignaler utility in pkg/daemon.

In Support of #2074

These tests cover the core error handling logic, including thread-safety, to ensure the daemon's lifecycle management is reliable.

Note: I initially planned to cover the entire package, but the NewDaemon function's use of a global client makes it difficult to mock. Rather than get blocked, this PR adds valuable, targeted tests for the self-contained errSignaler component as a good first step. We can tackle a refactor for broader test coverage in a follow-up.

@kruise-bot kruise-bot requested review from FillZpp and furykerry July 8, 2025 17:12
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign veophi for approval by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Jul 8, 2025
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.08%. Comparing base (f69813c) to head (7fb93d9).
⚠️ Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
+ Coverage   43.99%   44.08%   +0.09%     
==========================================
  Files         316      316              
  Lines       31844    31844              
==========================================
+ Hits        14009    14040      +31     
+ Misses      16425    16394      -31     
  Partials     1410     1410              
Flag Coverage Δ
unittests 44.08% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GautamBytes
Copy link
Contributor Author

@furykerry can you rerun the workflow ? the 2 failing workflows seems unrelated to my changes!

@stale
Copy link

stale bot commented Oct 30, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M size/M: 30-99 wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants