-
Notifications
You must be signed in to change notification settings - Fork 830
feat: Add volumeClaimTemplate to advanced DaemonSet #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: joey <[email protected]>
db4390f to
b6c3b54
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2115 +/- ##
==========================================
+ Coverage 44.28% 44.56% +0.27%
==========================================
Files 316 319 +3
Lines 31859 32365 +506
==========================================
+ Hits 14110 14424 +314
- Misses 16339 16511 +172
- Partials 1410 1430 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ### Implementation Details/Notes/Constraints | ||
|
|
||
| We should consider whether to delete the PVC when a node is deleted, and whether to delete the PVC when the ads is deleted. | ||
| We can add a `PersistentVolumeClaimRetentionPolicy`, with optional values of `Retain` and `Delete`, the default being `Retain`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the default policy should be delete, since there is no easy way to reuse the pvc if the node is deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition, we have to introduce a label to match pod and related pvc. In cloneset, pod and pvc with the same apps.kruise.io/cloneset-instance-id will be mounted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a discussion in the community call this week ?
|
@chengjoey: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
feat: #2112
Ⅲ. Describe how to verify it
unit-test\e2e-test
Ⅳ. Special notes for reviews
TODO: add PersistentVolumeClaimRetentionPolicy