Skip to content

Conversation

@7h3-3mp7y-m4n
Copy link
Contributor

@7h3-3mp7y-m4n 7h3-3mp7y-m4n commented Jul 31, 2025

Ⅰ. Describe what this PR does

  • created unit tests for pkg/webhook/util/convertor

Ⅱ. Does this pull request fix one issue?

fixes #2074

@kruise-bot kruise-bot requested review from furykerry and zmberg July 31, 2025 19:34
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.90%. Comparing base (e258de4) to head (20c799c).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
+ Coverage   44.81%   44.90%   +0.08%     
==========================================
  Files         318      318              
  Lines       32245    32245              
==========================================
+ Hits        14452    14481      +29     
+ Misses      16372    16342      -30     
- Partials     1421     1422       +1     
Flag Coverage Δ
unittests 44.90% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stale
Copy link

stale bot commented Oct 30, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 30, 2025
@stale stale bot closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L size/L: 100-499 wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Enhance Test Coverage for Kruise

2 participants