Skip to content

Conversation

@jwnasambu
Copy link
Contributor

Description of what changed
I bump queue module from 2.7.0-SNAPSHOT to 2.8.0-SNAPSHOT Since version 2.7.0 has been released.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 1, 2025

Did you look into why the e2e tests are failing?

@jwnasambu
Copy link
Contributor Author

@dkayiwa I am on the issue now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to change the app shell version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need this either.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 1, 2025

@jwnasambu can you do it like i previously did it before? 50c8e1b

@jwnasambu
Copy link
Contributor Author

@dkayiwa sure! right away.

@denniskigen denniskigen changed the title Bump_queue module to 2.8.0-SNAPSHOT Bump queue module to 2.8.0-SNAPSHOT Sep 1, 2025
@jwnasambu
Copy link
Contributor Author

@dkayiwa I have fixed the proposed changes.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 1, 2025

@jwnasambu
Copy link
Contributor Author

@dkayiwa it the link I am on know

@wikumChamith
Copy link
Member

@jwnasambu I’m seeing a bunch of changes in your PR that don’t seem related to bumping the module queue. Could you please double-check?

@jwnasambu
Copy link
Contributor Author

@dkayiwa I have looked at these https://github.com/openmrs/openmrs-distro-referenceapplication/pull/937/files to be honest I seem to be confusing myself more.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 1, 2025

Did you see @wikumChamith's response?

@denniskigen
Copy link
Member

This is the only line that should change.

@jwnasambu
Copy link
Contributor Author

@dkayiwa and @denniskigen thanks for the pointing

@jwnasambu
Copy link
Contributor Author

I am pushing changes shortly

@jwnasambu jwnasambu force-pushed the bump-queue-module-2.8.0-SNAPSHOT branch 2 times, most recently from 2e7e4d1 to fd15cf8 Compare September 1, 2025 14:58
@jwnasambu
Copy link
Contributor Author

jwnasambu commented Sep 1, 2025

@dkayiwa, @wikumChamith, @denniskigen I fixed the changes.

@dkayiwa
Copy link
Member

dkayiwa commented Sep 1, 2025

@jwnasambu isn't the version supposed to become 2.7.0?

@jwnasambu
Copy link
Contributor Author

jwnasambu commented Sep 1, 2025 via email

@jwnasambu jwnasambu force-pushed the bump-queue-module-2.8.0-SNAPSHOT branch from 2809d90 to f5095cf Compare September 1, 2025 19:27
@dkayiwa
Copy link
Member

dkayiwa commented Sep 1, 2025

@jwnasambu the release for 2.7.0 did not come out nicely. So i have just released version 2.8.0 that you can switch to.

@jwnasambu jwnasambu force-pushed the bump-queue-module-2.8.0-SNAPSHOT branch from 185a91e to 242a4a0 Compare September 2, 2025 04:18
@jwnasambu jwnasambu changed the title Bump queue module to 2.8.0-SNAPSHOT Bump queue module to version 2.8.0 Sep 2, 2025
@jwnasambu jwnasambu force-pushed the bump-queue-module-2.8.0-SNAPSHOT branch from 242a4a0 to 9531fef Compare September 2, 2025 04:27
@jwnasambu
Copy link
Contributor Author

Thanks @dkayiwa I have fixed the proposed changes

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwnasambu !

@jayasanka-sack jayasanka-sack merged commit e88e8ca into openmrs:main Sep 2, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants