-
Notifications
You must be signed in to change notification settings - Fork 502
Bump queue module to version 2.8.0 #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump queue module to version 2.8.0 #937
Conversation
|
Did you look into why the e2e tests are failing? |
|
@dkayiwa I am on the issue now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need to change the app shell version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need this either.
|
@jwnasambu can you do it like i previously did it before? 50c8e1b |
|
@dkayiwa sure! right away. |
|
@dkayiwa I have fixed the proposed changes. |
|
@jwnasambu did you get a chance to look at this? https://github.com/openmrs/openmrs-distro-referenceapplication/pull/937/files |
|
@dkayiwa it the link I am on know |
|
@jwnasambu I’m seeing a bunch of changes in your PR that don’t seem related to bumping the module queue. Could you please double-check? |
|
@dkayiwa I have looked at these https://github.com/openmrs/openmrs-distro-referenceapplication/pull/937/files to be honest I seem to be confusing myself more. |
|
Did you see @wikumChamith's response? |
|
This is the only line that should change. |
|
@dkayiwa and @denniskigen thanks for the pointing |
|
I am pushing changes shortly |
2e7e4d1 to
fd15cf8
Compare
|
@dkayiwa, @wikumChamith, @denniskigen I fixed the changes. |
|
@jwnasambu isn't the version supposed to become 2.7.0? |
|
I used 2. 8.0-snapshot because @wikum had released a new version of this module and I was just updating the distro.
Yahoo Mail: Search, Organize, Conquer
On Mon, Sep 1, 2025 at 7:26 PM, ***@***.***> wrote: dkayiwa left a comment (openmrs/openmrs-distro-referenceapplication#937)
@jwnasambu isn't the version supposed to become 2.7.0?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
2809d90 to
f5095cf
Compare
|
@jwnasambu the release for 2.7.0 did not come out nicely. So i have just released version 2.8.0 that you can switch to. |
185a91e to
242a4a0
Compare
242a4a0 to
9531fef
Compare
|
Thanks @dkayiwa I have fixed the proposed changes |
jayasanka-sack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwnasambu !
Description of what changed
I bump queue module from 2.7.0-SNAPSHOT to 2.8.0-SNAPSHOT Since version 2.7.0 has been released.