Skip to content

Conversation

@suikabreaker
Copy link
Contributor

@suikabreaker suikabreaker commented Jan 11, 2022

fix #61

@suikabreaker
Copy link
Contributor Author

@xiaocang may you spend some time on this PR?

@zhuizhuhaomeng
Copy link
Contributor

@xiaocang may you spend some time on this PR?

@suikabreaker tks for you PR.
We need to add some test cases to cover the new feature.

@suikabreaker
Copy link
Contributor Author

I've mistakenly add the feature based on a fork... and this PR contains two new featrues. I'll rearrange it.

@suikabreaker
Copy link
Contributor Author

@xiaocang may you spend some time on this PR?

@suikabreaker tks for you PR. We need to add some test cases to cover the new feature.

@zhuizhuhaomeng I've split this PR into two, each implements one feature, and added tests for them. May you review those PRs?

#64

#63

@xiaocang
Copy link

xiaocang commented Mar 4, 2022

ok, I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support optional compatibility to LF as line break

4 participants