Adapt ActionFilter interface implementation to core change #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibix
requested review from
epugh,
jzonthemtn,
msfroh and
sstults
as code owners
Contributor
Author
|
This does not compile at the moment, build.gradle still specified OpenSearch core in version 3.3.0-SNAPSHOT; this can be only applied when it is bumped to 3.4.0-SNAPSHOT. I am moving this PR to draft status until this is changed. |
Collaborator
|
@nibix i think i merged the right PR's... Do you want to move this back to ready for review? |
epugh
approved these changes
Oct 27, 2025
Collaborator
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Thanks for the PR and helping us stay up to date!
The PR opensearch-project/OpenSearch#18523 needs to add a new parameter to the apply() method of the ActionFilter interface. This adds the parameter to the ActionFilter implementations. Signed-off-by: Nils Bandener <[email protected]>
nibix
force-pushed
the
action-filter-extension
branch
from
c231b6c to
62a9dc5
Compare
Contributor
Author
|
It's a pleasure! :-) I have rebased it and marked it as ready for review! |
Collaborator
|
Incidentally, I'd like to call out that this PR inspired this one: opensearch-project/cluster-etcd#57 |
jzonthemtn
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The core PR opensearch-project/OpenSearch#18523 has changed the
ActionFilterinterface by adding a newapply()method with an additional parameter. The oldapply()method is now deprecated. This change adds the parameter to the ActionFilter implementations.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.