Skip to content

Conversation

@jnan806
Copy link
Collaborator

@jnan806 jnan806 commented Dec 5, 2022

Signed-off-by: Jiangnan Jia [email protected]

Describe what this PR does / why we need it

  1. with functional option style can make the API more convenient
    2. SDK now lacks a retry mechanism when connect to the transport stream
    3. invoke chain in the code is too long, need to re-format

Does this pull request fix one issue?

Fixes #21

Describe how you did it

  1. add an functional option in package api, and add param in NewOpenSergoClient
    2. introduce the retry-go component to realize retry mechanism
    3. re-format the code by extract func and struct

Describe how to verify it

Special notes for reviews

@jnan806 jnan806 requested a review from sczyh30 December 5, 2022 14:21
@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label Dec 5, 2022
@jnan806 jnan806 marked this pull request as draft December 5, 2022 15:25
@jnan806 jnan806 force-pushed the polish-func-name branch 2 times, most recently from 38e682f to 363d502 Compare December 6, 2022 06:26
@jnan806 jnan806 changed the title Extract independent func for the long func-invoke chain Optimize functional option style API and add a retry mechanism of connect Dec 6, 2022
@jnan806 jnan806 marked this pull request as ready for review December 6, 2022 07:03
@jnan806 jnan806 added the kind/feature Category issues or PRs related to feature request label Dec 6, 2022
@jnan806 jnan806 marked this pull request as draft December 6, 2022 07:08
@jnan806 jnan806 marked this pull request as ready for review December 6, 2022 07:54
@jnan806 jnan806 marked this pull request as draft February 9, 2023 05:10
@jnan806 jnan806 marked this pull request as ready for review February 9, 2023 05:10
@jnan806 jnan806 changed the title Optimize functional option style API and add a retry mechanism of connect Optimize functional option style API Feb 14, 2023
Support API-Style Options
@jnan806 jnan806 changed the title Optimize functional option style API Support functional option style API Mar 9, 2023
@jnan806
Copy link
Collaborator Author

jnan806 commented Mar 13, 2023

@sczyh30 PTAL

@sczyh30
Copy link
Member

sczyh30 commented Mar 29, 2023

Also cc @binbin0325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Category issues or PRs related to enhancement kind/feature Category issues or PRs related to feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve client NewOpenSergoClient API with functional option style.

2 participants