Skip to content

WIP MON-4432: Add e2e test for network DaemonSet target discovery #30627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
slashpai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP MON-4432: Add e2e test for network DaemonSet target discovery #30627

slashpai wants to merge 1 commit into from
+11 −0

Conversation

@slashpai
Copy link
Member

@slashpai slashpai commented Dec 19, 2025 •
edited
Loading

Add a test to verify that network DaemonSet ServiceMonitor targets
are correctly discovered.

This validates the changes from openshift/cluster-network-operator#2839
which migrates DaemonSet ServiceMonitors to use EndpointSlice
instead of the Endpoints API.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025 •
edited by openshift-ci bot
Loading

@slashpai: This pull request references MON-4432 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add a test to verify that network DaemonSet ServiceMonitor targets are correctly discovered and scraped when using EndpointSlice for service discovery.

This validates the changes from openshift/cluster-network-operator#2839 which migrates DaemonSet ServiceMonitors to use EndpointSlice instead of the Endpoints API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2025
@slashpai slashpai mentioned this pull request Dec 19, 2025
Open
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

simonpasquier
simonpasquier reviewed Dec 19, 2025
View reviewed changes
@openshift-trt
Copy link

openshift-trt bot commented Dec 19, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 4b141ea

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor targets with EndpointSlice discovery [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-gcp-ovn High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor targets with EndpointSlice discovery [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor targets with EndpointSlice discovery [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor targets with EndpointSlice discovery [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor targets with EndpointSlice discovery [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: 4b141ea

  • "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor targets with EndpointSlice discovery [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 0, Fail: 5, Flake: 0]

@slashpai
MON-4432: Add e2e test for network DaemonSet EndpointSlice discovery
dbb701f 
Add a test to verify that network DaemonSet ServiceMonitor targets
are correctly discovered.

This validates the changes from openshift/cluster-network-operator#2839
which migrates DaemonSet ServiceMonitors to use EndpointSlice
instead of the Endpoints API.

Signed-off-by: Jayapriya Pai <[email protected]>
Assisted-By: Cursor AI
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025 •
edited by openshift-ci bot
Loading

@slashpai: This pull request references MON-4432 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add a test to verify that network DaemonSet ServiceMonitor targets
are correctly discovered.

This validates the changes from openshift/cluster-network-operator#2839
which migrates DaemonSet ServiceMonitors to use EndpointSlice
instead of the Endpoints API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@slashpai slashpai changed the title WIP MON-4432: Add e2e test for network DaemonSet EndpointSlice discovery WIP MON-4432: Add e2e test for network DaemonSet target discovery Dec 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@slashpai
Copy link
Member Author

slashpai commented Dec 23, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2025

@slashpai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 dbb701f link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-fips dbb701f link true /test e2e-aws-ovn-fips
ci/prow/e2e-vsphere-ovn dbb701f link true /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-upi dbb701f link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-ovn dbb701f link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Dec 23, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: dbb701f

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor target [Suite:openshift/conformance/parallel]" is a new test that failed 2 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-gcp-ovn High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor target [Suite:openshift/conformance/parallel]" is a new test that failed 2 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor target [Suite:openshift/conformance/parallel]" is a new test that failed 2 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor target [Suite:openshift/conformance/parallel]" is a new test that failed 2 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor target [Suite:openshift/conformance/parallel]" is a new test that failed 2 time(s) against the current commit

New tests seen in this PR at sha: dbb701f

  • "[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should have working network DaemonSet ServiceMonitor target [Suite:openshift/conformance/parallel]" [Total: 10, Pass: 0, Fail: 10, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan--f jan--f Awaiting requested review from jan--f

1 more reviewer

@simonpasquier simonpasquier simonpasquier left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slashpai @openshift-ci-robot @simonpasquier