Skip to content

[OVMS 2025.4.1] Removing unused parameter from embeddings tokenize function #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

[OVMS 2025.4.1] Removing unused parameter from embeddings tokenize function #3827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d2b6b
removed unused parameter
przepeck Nov 28, 2025
859e1e2
fix
przepeck Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/embeddings/embeddings_calculator_ov.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class EmbeddingsCalculatorOV : public CalculatorBase {

mediapipe::Timestamp timestamp{0};

absl::Status tokenizeStrings(ov::genai::Tokenizer& tokenizer, const std::vector<std::string>& inputStrings, const ov::AnyMap& parameters, ov::genai::TokenizedInputs& tokens, const size_t& max_context_length) {
absl::Status tokenizeStrings(ov::genai::Tokenizer& tokenizer, const std::vector<std::string>& inputStrings, const ov::AnyMap& parameters, ov::genai::TokenizedInputs& tokens) {
tokens = tokenizer.encode(inputStrings, parameters);
RET_CHECK(tokens.input_ids.get_shape().size() == 2);

Expand Down Expand Up @@ -131,7 +131,7 @@ class EmbeddingsCalculatorOV : public CalculatorBase {
}
auto input = tokenizeRequest.input;
if (auto strings = std::get_if<std::vector<std::string>>(&input)) {
auto tokenizationStatus = this->tokenizeStrings(embeddings_session->getTokenizer(), *strings, tokenizeRequest.parameters, tokens, max_context_length);
auto tokenizationStatus = this->tokenizeStrings(embeddings_session->getTokenizer(), *strings, tokenizeRequest.parameters, tokens);
if (!tokenizationStatus.ok()) {
return tokenizationStatus;
}
Expand Down Expand Up @@ -169,7 +169,7 @@ class EmbeddingsCalculatorOV : public CalculatorBase {
params["max_length"] = max_context_length;
}

absl::Status tokenizationStatus = this->tokenizeStrings(embeddings_session->getTokenizer(), *strings, params, tokens, max_context_length);
absl::Status tokenizationStatus = this->tokenizeStrings(embeddings_session->getTokenizer(), *strings, params, tokens);
if (!tokenizationStatus.ok()) {
return tokenizationStatus;
}
Expand Down