Fix 'Can not access non-const pointer' exception when running Phi-4-multimodal model #3064
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wovchena
reviewed
Nov 25, 2025
| std::vector<std::variant<ov::Tensor, size_t>> drop_image_placeholders(const ov::Tensor& tokens) { | ||
| std::vector<std::variant<ov::Tensor, size_t>> drop_image_placeholders(int64_t* tokens, const ov::Shape& shape) { | ||
| std::vector<std::variant<ov::Tensor, size_t>> chunks; | ||
| int64_t last_token = tokens.data<int64_t>()[0]; |
Collaborator
There was a problem hiding this comment.
Is there a way to use const version of data()? The underlying memory isn't affected.
@sgonorov, please update your PR to include the fix if it's truly needed #3026
@mateusztabaka, as you can see I'm leaving it to @sgonorov. Let us know if you aren't OK with that
Author
There was a problem hiding this comment.
Is there a way to use const version of data()? The underlying memory isn't affected.
Yes, however non-const pointer has to be passed to ov::Tensor constructor to make it work.
@mateusztabaka, as you can see I'm leaving it to @sgonorov. Let us know if you aren't OK with that
I'm fine with that. @sgonorov let me know when you pull my change so I can test your branch then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.