Skip to content

[core] Remove deprecated ov::element:undefined #32573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[core] Remove deprecated ov::element:undefined #32573

wants to merge 4 commits into from
+71 −124

Conversation

@walidbarakat
Copy link

@walidbarakat walidbarakat commented Oct 27, 2025

remove deprecated ov::element type undefined to have dynamic type used instead.

Tickets:

@walidbarakat walidbarakat requested review from a team as code owners October 27, 2025 16:41
@walidbarakat walidbarakat requested review from kblaszczak-intel and removed request for a team October 27, 2025 16:41
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: C API OpenVINO C API bindings category: docs OpenVINO documentation category: CPP API OpenVINO CPP API bindings labels Oct 27, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalIntelPR External contributor from Intel label Oct 27, 2025
@mlukasze mlukasze added this to the 2026.0 milestone Oct 28, 2025
@mlukasze
Copy link
Contributor

mlukasze commented Oct 28, 2025

please, do not merge before the 25.4 code freeze

@praasz praasz self-assigned this Oct 28, 2025
@walidbarakat walidbarakat force-pushed the CVS-161775/clean_deprecated_ov_element_undefined branch from 8a32021 to e6e34de Compare October 28, 2025 12:58
@t-jankowski t-jankowski changed the title [CVS-161775] remove deprecated ov::element:undefined [core] Remove deprecated ov::element:undefined Oct 28, 2025
@t-jankowski
Copy link
Contributor

t-jankowski commented Oct 29, 2025

Ok for core and c-api parts.

@praasz
Copy link
Contributor

praasz commented Nov 3, 2025

@build_jenkins

olpipi
olpipi reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@olpipi olpipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just fix the formatting please

src/bindings/c/src/ov_tensor.cpp Outdated
{ov_element_type_e::STRING, ov::element::string},
{ov_element_type_e::F4E2M1, ov::element::f4e2m1},
{ov_element_type_e::F8E8M0, ov::element::f8e8m0},
{ov_element_type_e::DYNAMIC, ov::element::dynamic}, {ov_element_type_e::BOOLEAN, ov::element::boolean},
Copy link
Contributor

@olpipi olpipi Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please return enumeration of types to 1 column? It seems confusing to me

Copy link
Author

@walidbarakat walidbarakat Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried this, but clang format reported this as an issue on CI and locally as well. should i get it back to 1 column again anyway?

Copy link
Contributor

@t-jankowski t-jankowski Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try // clang-format off line before and on again afterwards

Copy link
Author

@walidbarakat walidbarakat Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@praasz
Copy link
Contributor

praasz commented Nov 7, 2025

@Aliczi @Retribution98 Could you check if there is any update required from bindings?

almilosz
almilosz reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@almilosz almilosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, python api warning should be removed from here but it can be done separately.
JS part no changes needed

@walidbarakat
[CVS-161775][core] remove deprecated ov::element:undefined
d071e16 
remove deprecated ov::element type undefined to have
dynamic type used instead.

Signed-off-by: Walid Aly <[email protected]>
@walidbarakat
[CVS-161775][Py OV] remove deprecated undefined type and warning message
0081ae1 
remove deprecated undefined type and warning message

Signed-off-by: Walid Aly <[email protected]>
@walidbarakat walidbarakat force-pushed the CVS-161775/clean_deprecated_ov_element_undefined branch from e6e34de to 0081ae1 Compare November 13, 2025 08:34
@walidbarakat walidbarakat requested review from a team as code owners November 13, 2025 08:34
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: ONNX FE OpenVINO ONNX FrontEnd category: OVC OVC tool labels Nov 13, 2025
almilosz
almilosz reviewed Nov 13, 2025
View reviewed changes
docs/articles_en/about-openvino/release-notes-openvino.rst

Deprecated and to be removed in the future
--------------------------------------------
* ``openvino.Type.undefined`` is now deprecated and will be removed with version 2026.0.
Copy link
Contributor

@almilosz almilosz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section about 25.0 should be kept. Later, for 2026.0 we will add an entry that Type.undefined was removed

Copy link
Author

@walidbarakat walidbarakat Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i think this PR is targeted to be merged for 2026.0 release. should this change to inform that Type.undefined is removed already?

Copy link
Contributor

@almilosz almilosz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik usually there is a big pr with updates to release-notes. It makes sense to remove this part, but I am not sure what other changes are necessary @tsavina

@walidbarakat
Copy link
Author

walidbarakat commented Nov 17, 2025

@build_jenkins

@praasz
Copy link
Contributor

praasz commented Nov 21, 2025

build_jenkins

@praasz praasz enabled auto-merge November 21, 2025 10:14
@praasz praasz requested a review from olpipi November 21, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-jankowski t-jankowski t-jankowski approved these changes

@almilosz almilosz almilosz approved these changes

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@olpipi olpipi Awaiting requested review from olpipi

Assignees

@Retribution98 Retribution98

@praasz praasz

@almilosz almilosz

Labels

category: C API OpenVINO C API bindings category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: docs OpenVINO documentation category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: ONNX FE OpenVINO ONNX FrontEnd category: OVC OVC tool category: Python API OpenVINO Python bindings ExternalIntelPR External contributor from Intel

Projects

None yet

Milestone

2026.0

Development

Successfully merging this pull request may close these issues.

8 participants

@walidbarakat @mlukasze @t-jankowski @praasz @olpipi @almilosz @Retribution98 @sys-openvino-ci