Skip to content

Conversation

@mvafin
Copy link
Contributor

@mvafin mvafin commented Nov 4, 2025

Details:

  • Fix segmentation faults when running editor tests with onnx delegate

Tickets:

  • ticket-id

@mvafin mvafin requested a review from a team as a code owner November 4, 2025 11:09
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses segmentation faults in ONNX editor tests by adding null pointer checks before calling methods on potentially null objects. The changes ensure that tests fail gracefully with informative error messages rather than crashing.

Key Changes

  • Added ASSERT_TRUE checks to verify pointers are not null before dereferencing
  • Added ASSERT_GE checks to ensure containers have sufficient elements before indexing
  • Refactored chained method calls into separate variables with intermediate null checks
Comments suppressed due to low confidence (1)

src/frontends/onnx/tests/onnx_editor.cpp:453

  • Test name appears truncated: 'subgraph__twice_input_edge_from_tensor_with_single_co' should likely be 'subgraph__twice_input_edge_from_tensor_with_single_consumer' or similar.
OPENVINO_TEST(onnx_editor, subgraph__twice_input_edge_from_tensor_with_single_consumer) {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@bumbosiepsak bumbosiepsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and has quality messages.

@mvafin mvafin added this pull request to the merge queue Nov 6, 2025
@mvafin mvafin changed the title [ONNX] Fix editor tests to check for nullptr before calling mathods [ONNX] Fix editor tests to check for nullptr before dereferencing Nov 6, 2025
@mvafin mvafin added this to the 2026.0 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ONNX FE OpenVINO ONNX FrontEnd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants