-
Notifications
You must be signed in to change notification settings - Fork 239
feat: create transport session repository #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: create transport session repository #2295
Conversation
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
|
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
|
Discussed on the WG. Overall approach makes sense, but we need to think about how the current TransportSession (bound to Http/Ws) relates to a TransportSession we need for instance sending. So the implementer of the transport session repository should also have control over the actual transport sessions. Or it could be that we still have Ws/Http session, and the custom repository implementation can add other types as well for other instances of Credo. |
|
@genaris to take a look at the PR and give some ideas. Goal is to make it very open to different implementations / architectures. single vs multi instance. Or handling sending within agents or through an external server (e.g. socketdock). |
Summary