Skip to content

Conversation

@sairanjit
Copy link
Member

@sairanjit sairanjit commented May 22, 2025

Summary

  • This is a start to add support for a custom transport session repository. The approach will change based on the feedback on the handling of the sessions.
  • This is a WIP PR created to get feedback from the community.

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 7fba33a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
Copy link
Contributor

Discussed on the WG. Overall approach makes sense, but we need to think about how the current TransportSession (bound to Http/Ws) relates to a TransportSession we need for instance sending.

So the implementer of the transport session repository should also have control over the actual transport sessions.

Or it could be that we still have Ws/Http session, and the custom repository implementation can add other types as well for other instances of Credo.

@TimoGlastra
Copy link
Contributor

@genaris to take a look at the PR and give some ideas. Goal is to make it very open to different implementations / architectures. single vs multi instance. Or handling sending within agents or through an external server (e.g. socketdock).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants