-
Notifications
You must be signed in to change notification settings - Fork 3
Fix iOS resource loading and build configuration #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @TheBlackBit , I’ve tested it and confirmed that it works — here’s the video: link. Regarding the .pem file change — it’s a temporary modification. I believe the current code already has some problems to the .pem, which are tracked in this ticket to fix the problem. Also if you find a better solution for this ios build problem , don't hestitate to share it :) |
Sure Hanlu |
VishnuSanal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Hanlu, please see the comments. also, is there any guide that we can link to in the documentatino for reference?
...azGettingStartedSample/composeApp/src/commonMain/composeResources/files/iaca_private_key.pem
Show resolved
Hide resolved
...le/composeApp/src/commonMain/composeResources/files/provisioning_attestation_private_key.pem
Outdated
Show resolved
Hide resolved
MultipazGettingStartedSample/composeApp/src/commonMain/kotlin/org/multipaz/getstarted/App.kt
Outdated
Show resolved
Hide resolved
MultipazGettingStartedSample/composeApp/src/commonMain/kotlin/org/multipaz/getstarted/App.kt
Outdated
Show resolved
Hide resolved
MultipazGettingStartedSample/composeApp/src/commonMain/kotlin/org/multipaz/getstarted/App.kt
Outdated
Show resolved
Hide resolved
MultipazGettingStartedSample/composeApp/src/commonMain/kotlin/org/multipaz/getstarted/App.kt
Outdated
Show resolved
Hide resolved
MultipazGettingStartedSample/composeApp/src/commonMain/kotlin/org/multipaz/getstarted/App.kt
Outdated
Show resolved
Hide resolved
6f42e50 to
b3e851f
Compare
Resolved facenet can't compile problems by add podfile Resolved MissingResourceException for .pem certificate files on iOS by: - Updated composeApp.podspec to explicitly copy PEM files from src/commonMain/composeResources/files into the app bundle during build - Added hardcoded package name fallback for resource path resolution - Ensured compose resources are properly packaged in iosApp.app bundle This version only works for iOS with ARM chips. Build steps for iOS: Step 1 - Gradle preparation: ./gradlew :composeApp:clean ./gradlew :composeApp:generateDummyFramework ./gradlew :composeApp:prepareComposeResourcesTaskForCommonMain Step 2 - CocoaPods: pod install Step 3 - Xcode build: 1. Open iosApp.xcworkspace in Xcode 2. Set up Team and Bundle Identifier in project settings 3. Product → Clean Build Folder 4. Product → Run minor change for ios build issues
b3e851f to
f281859
Compare
|
Hi @koukarine, these are our changes to support facenet for iOS. You can test it using the steps listed below: Build steps for iOS:
Please see this video for reference. Feel free to add your suggestion, thanks a lot! |
VishnuSanal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks hanlu!
...azGettingStartedSample/composeApp/src/commonMain/composeResources/files/iaca_private_key.pem
Show resolved
Hide resolved
TheBlackBit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as well
koukarine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would just make sure the documentation is stating that it should be done on MAC workstation and that cocoapods might require the specific installation procedure to work with KMP (there are several guides available online for that).
Also, I'm a bit puzzled that the dedicated gradle task is required for the "Dummy framework" copying. I can't tell for sure, as the multipaz iOS setup was done without me, but I believe the Android Studio is taking care of cocoapods dependencies automatically in the KMP project when the Podfile is detected. However, your project structure might be different, and thus requiring that step.
Thanks Alex for your feedback. |
Resolved facenet can't compile problems in ios by add podfile
Resolved MissingResourceException for .pem certificate files on iOS by:
This version only works for iOS with ARM chips.
**Build steps for iOS:
Step 1 - Gradle preparation:
./gradlew :composeApp:clean
./gradlew :composeApp:generateDummyFramework
./gradlew :composeApp:prepareComposeResourcesTaskForCommonMain
Step 2 - CocoaPods:
pod install
Step 3 - Xcode build: