Skip to content

fix crash when the requested document is not present in the holder #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
VishnuSanal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix crash when the requested document is not present in the holder #1409

VishnuSanal wants to merge 1 commit into from
+119 −67

Conversation

@VishnuSanal
Copy link
Member

@VishnuSanal VishnuSanal commented Nov 14, 2025 •
edited
Loading

Fixes #1408

  • Tests pass (manually tested with and without empty documentStore)
  • Appropriate changes to README are included in PR

steps to test

  • build testapp
  • try to request for a document type that is not present in the documentstore (or delete all docs from the document store and request for any doc type)
  • you should see a "no matching document present" bottom sheet - the app used to crash previously

@VishnuSanal VishnuSanal marked this pull request as ready for review November 15, 2025 06:30
TheBlackBit
TheBlackBit approved these changes Nov 17, 2025
View reviewed changes
Copy link

@TheBlackBit TheBlackBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@davidz25
Copy link
Contributor

davidz25 commented Nov 18, 2025

We should definitely not crash but I'm also not sure we should be showing CredentialPresentmentModalBottomSheet in the first place if we don't have any matches... it feels like this is a bug in PresentmentModel, it needs to probably do something else than show this bottom sheet when there are no matches.

@VishnuSanal VishnuSanal marked this pull request as draft November 28, 2025 11:29
@VishnuSanal

This comment was marked as outdated.

Sign in to view
@VishnuSanal VishnuSanal marked this pull request as ready for review December 8, 2025 15:44
@VishnuSanal
Copy link
Member Author

VishnuSanal commented Dec 8, 2025

@davidz25 I have updated the code with the approach we discussed in the meeting last week. I think this PR is ready for review - can you please take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz25 davidz25 Awaiting requested review from davidz25

@hanluOMH hanluOMH Awaiting requested review from hanluOMH

1 more reviewer

@TheBlackBit TheBlackBit TheBlackBit approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash when the requested document is not present in the holder

3 participants

@VishnuSanal @davidz25 @TheBlackBit