Skip to content

Document Carousel Composable Implementation #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aboheneadu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document Carousel Composable Implementation #1425

aboheneadu wants to merge 1 commit into from
+562 −148

Conversation

@aboheneadu
Copy link
Contributor

@aboheneadu aboheneadu commented Nov 25, 2025 •
edited
Loading

Fixes #1400

  • Implemented Document Carousel
  • Moved DocumentModel, CredentialInfo and DocumentInfo into mutlipaz-compose module
  • Added Document Carousel to testApp module
  • Refactored DocumentModel

UI Changes

Document Carousel Default Card Art
https://github.com/user-attachments/assets/7c3455aa-f859-4877-8722-fa82b917ac08 d_art

@aboheneadu aboheneadu force-pushed the implement-document-carousel branch 3 times, most recently from 74eb58c to a927a7d Compare November 25, 2025 16:42
@aboheneadu aboheneadu requested a review from davidz25 November 25, 2025 17:38
@aboheneadu aboheneadu marked this pull request as ready for review November 25, 2025 17:38
davidz25
davidz25 reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

@davidz25 davidz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start! Left some comments inline. Btw, one thing I noticed is that your code isn't consistent in its use of whitespace... sometimes space is missing between closing ) and opening {, other times there's no blank line between functions.

Our coding style is spelled out in CODING-STYLE.md and basically sums up to that we're using the standard Kotlin coding conventions.

@aboheneadu aboheneadu force-pushed the implement-document-carousel branch 2 times, most recently from 468f8f3 to b3e9718 Compare December 1, 2025 20:06
@aboheneadu aboheneadu requested a review from davidz25 December 1, 2025 20:08
davidz25
davidz25 reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

@davidz25 davidz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes - some new comments inline!

@aboheneadu aboheneadu force-pushed the implement-document-carousel branch 2 times, most recently from a9dd327 to b90b2b7 Compare December 9, 2025 05:20
@aboheneadu aboheneadu force-pushed the implement-document-carousel branch from b90b2b7 to d11243b Compare December 9, 2025 12:51
@aboheneadu aboheneadu requested a review from davidz25 December 9, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz25 davidz25 Awaiting requested review from davidz25

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document Carousel composable

3 participants

@aboheneadu @davidz25