iokit sync #106
Open
iokit sync #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IS_EMPTY macro does not catch case where tqent_prev and tqent_next are NULL
Allow kstat.zfs.darwin.tunable.use_system_sync to control whether we use the post-10.11 IOKit barrier sync or not. Do not call the synchronize method a second time in the same invocation of handle_sync_iokit. Log the IOReturn error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handle_sync_iokit commit needs @me eyeballs on what should be passed
upwards in the event of failure, and whether recovery can be done cleverly in
some caller.