Replace github.com/golang/mock with go.uber.org/mock #3708
Merged
+2,089
−1,028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/golang/mock has been archived since June 2023. Update to the maintained library. Updated `yq` in bingo to be a version that uses go.uber.org/mock The latest available `helm` still uses github.com/golang/mock The latest 1.x of golangci-lint still use github.com/golang/mock Signed-off-by: Todd Short <[email protected]>
anik120
approved these changes
Nov 14, 2025
Member
anik120
left a comment
anik120
left a comment
There was a problem hiding this comment.
https://github.com/uber-go/mock latest is v0.6.0 👍🏽
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 7cfea3d
into
operator-framework:master
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
github.com/golang/mock has been archived since June 2023.
Update to the maintained library.
Updated
yqin bingo to be a version that uses go.uber.org/mock The latest availablehelmstill uses github.com/golang/mock The latest 1.x of golangci-lint still use github.com/golang/mockReviewer Checklist
/doc[FLAKE]are truly flaky and have an issue