-
Notifications
You must be signed in to change notification settings - Fork 111
Rewrite Groovy into Java #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vjovanov
wants to merge
12
commits into
master
Choose a base branch
from
vj/rewrite-java
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
211e071
tck-build-logic: migrate CoordinatesAwareTask from Groovy to Java; pr…
vjovanov dfb1e91
tck-build-logic: migrate AllCoordinatesExecTask from Groovy to Java; …
vjovanov 8a65a90
tck-build-logic: migrate SingleCoordinateTask from Groovy to Java; pr…
vjovanov 51c4f69
tck-build-logic: migrate AbstractSubprojectTask from Groovy to Java; …
vjovanov 76ffef7
tck-build-logic: migrate CheckstyleInvocationTask from Groovy to Java…
vjovanov 39b2dfb
tck-build-logic: migrate CleanInvocationTask from Groovy to Java; pre…
vjovanov ca4ab1d
tck-build-logic: migrate CompileTestJavaInvocationTask from Groovy to…
vjovanov 7f7726d
tck-build-logic: migrate JavaTestInvocationTask from Groovy to Java; …
vjovanov 8bfde85
tck-build-logic: migrate NativeTestCompileInvocationTask from Groovy …
vjovanov 7140a8e
tck-build-logic: migrate FetchExistingLibrariesWithNewerVersionsTask …
vjovanov 4871b39
tck-build-logic: migrate TestInvocationTask from Groovy to Java; pres…
vjovanov 7423c62
tck-build-logic: make test directory resolution robust; fallback to c…
vjovanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
174 changes: 0 additions & 174 deletions
174
...ogic/src/main/groovy/org/graalvm/internal/tck/harness/tasks/AbstractSubprojectTask.groovy
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So previously we only matched using
tests/src/index.json, and failed otherwise? These fallbacks will be useful once we get rid of thatindex.json.