Skip to content

Conversation

@sosukesuzuki
Copy link
Member

Build failing on oven-sh/bun#22517 is caused by this BUN_JSC_ADDITION.

So remove it for now.

@coderabbitai
Copy link

coderabbitai bot commented Sep 9, 2025

Walkthrough

Removed the AsyncFunctionWrapper parse-mode check under USE(BUN_JSC_ADDITIONS) in Interpreter::getStackTrace. The function now unconditionally appends a StackFrame for non-builtin code blocks. No other logic paths or public declarations were modified.

Changes

Cohort / File(s) Summary
Interpreter stack trace handling
Source/JavaScriptCore/interpreter/Interpreter.cpp
Deleted the isAsyncFunctionWrapperParseMode gating and related preprocessor block; getStackTrace now always appends the StackFrame for non-builtin code blocks. No other changes.

Pre-merge checks (1 passed, 2 warnings)

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The current description does not follow the repository’s required template, as it omits a Bugzilla bug link, the “Reviewed by” line, a clear explanation of how the change fixes the issue, and the structured file-by-file change summary expected by the template. Please update the description to match the repository’s PR template by including the Bugzilla bug title and link, a “Reviewed by” line, a detailed explanation of why removing BUN_JSC_ADDITION resolves the build failure, and a per-file change list showing which functions or lines were altered.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title directly references the removal of the BUN_JSC_ADDITION macro, which is the primary change in the diff, and it highlights the intent to stop hiding an extra stack frame, so it clearly captures the main change in the pull request.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 51b17a9 and 728b291.

📒 Files selected for processing (1)
  • Source/JavaScriptCore/interpreter/Interpreter.cpp (0 hunks)
💤 Files with no reviewable changes (1)
  • Source/JavaScriptCore/interpreter/Interpreter.cpp
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-needless-bun-addition

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jarred-Sumner Jarred-Sumner merged commit 2d2e8dd into main Sep 9, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants