Skip to content

Conversation

@vwong
Copy link
Collaborator

@vwong vwong commented Mar 12, 2025

No description provided.

@vwong vwong marked this pull request as ready for review March 13, 2025 02:52
boolean
>;

export const DEFAULT_CONFIG: Config = new Map([

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan to use this? Does it allow us to to enable an error and fix it one by one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my new commit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't quite finished with the PR

Copy link

@tuan-pham tuan-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 52 to 56
for (const [key, value] of Object.entries(this.#oas.info)) {
if (key.startsWith("x-opc-config-")) {
this.#config.set(key.substring(13), value);
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuan-pham I got distracted and didn't get around to committing this.

See https://swagger.io/docs/specification/v3_0/openapi-extensions/

@vwong vwong merged commit 0d0f5bf into main Mar 13, 2025
1 check passed
@vwong vwong deleted the feat/fine-grained-quirks branch March 13, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants