Skip to content

Conversation

@vwong
Copy link
Collaborator

@vwong vwong commented Mar 14, 2025

Also bundle in patched version of ajv so that consumers of this package don't have to worry about it

@JP-Ellis
Copy link
Contributor

Just for my own curiosity: why Rollup? I'm not super up-to-date with the JS/TS world, and haven't really heard of it (unlike Vite and Webpack). (feel free to link to a blog that might explain that)

@vwong
Copy link
Collaborator Author

vwong commented Mar 14, 2025

Vite uses rollup under the hood for production builds (but not for dev builds).

To be honest, I'm equally confused by so many tools having overlapping capabilities. I switched from esbuild to rollup because it allowed me to achieve what I wanted to, which is to patch ajv here, and build a bundled version that has the patched version. Consumers of this package don't have to worry about patching ajv.

"moduleResolution": "bundler",
"noEmit": true,
"outDir": "dist",
"rootDir": ".",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the setting to replace relative path to #path/to/file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@@ -1,22 +0,0 @@
import { build, BuildOptions } from "esbuild";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So rollup will replace esbuild?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw your answer to Josh's question. We are replacing esbuild with rollup

@vwong vwong merged commit 992d03c into main Mar 14, 2025
2 checks passed
@vwong vwong deleted the chore/switch-to-rollup branch March 14, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants