Skip to content

fix: don't raise errors when pact has no interactions #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vwong merged 1 commit into from
Mar 17, 2025
Merged

fix: don't raise errors when pact has no interactions #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/__tests__/fixtures/no-pacts-found/oas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,4 @@ info:
title: OAS
version: 1.0.0

paths:
/exists:
get:
responses:
"200":
description: description
content:
"application/json":
schema: {}
paths: {}
8 changes: 1 addition & 7 deletions src/__tests__/fixtures/no-pacts-found/opc-results.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
[
{
"code": "pact-broker.no-pacts-found",
"message": "No consumer pacts found in Pact Broker",
"type": "warning"
}
]
[]
8 changes: 0 additions & 8 deletions src/compare/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,6 @@ export class Comparator {

const parsedPact = parsePact(pact);

if (parsedPact.interactions.length === 0) {
yield {
code: "pact-broker.no-pacts-found",
message: "No consumer pacts found in Pact Broker",
type: "warning",
};
}

for (const [index, interaction] of parsedPact.interactions.entries()) {
const { method, path, query } = interaction.request;
let pathWithLeadingSlash = path.startsWith("/") ? path : `/${path}`;
Expand Down