Skip to content

Refactor PackageLoader to use importlib_resources #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor PackageLoader to use importlib_resources #1985

wants to merge 1 commit into from

Conversation

@danwuSBU
Copy link

@danwuSBU danwuSBU commented May 21, 2024

  • pip installed importlib-resources
  • added importlib-resources to docs.in tests.in typing.in and pip-compiled them
  • refactored PackageLoader to use importlib_resources

fixes #1978

@danwuSBU
Copy link
Author

danwuSBU commented May 22, 2024 •
edited
Loading

have to see why this is failing on Windows

@danwuSBU danwuSBU force-pushed the jinja#1978 branch 2 times, most recently from 9c832b7 to e3dd3de Compare May 22, 2024 04:09
@davidism davidism added this to the 3.2.0 milestone Dec 20, 2024
@dnicolodi dnicolodi mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

refactor PackageLoader to use importlib.resources

2 participants

@danwuSBU @davidism