Drop ANN exceptions from arrays and core/base.py #1568

loicdiridollou · 2025-12-18T19:07:32Z

Closes #xxxx (Replace xxxx with the Github issue number)
Tests added (Please use assert_type() to assert the type of any return value)
If I used AI to develop this pull request, I prompted it to follow AGENTS.md.

Quite a bit of clean up to comply with ANN rules.

Co-authored-by: Yi-Fan Wang <[email protected]>

cmp0xff

Just reviewed a small portion of all changes.

cmp0xff · 2025-12-18T22:21:01Z

pandas-stubs/io/excel/_base.pyi

        storage_options: StorageOptions = ...,
        engine_kwargs: dict[str, Any] | None = ...,
    ) -> None: ...
-    def __fspath__(self): ...


I think this is functional: https://docs.python.org/3/library/os.html#os.PathLike.__fspath__

should return a string, according to the implementation

Since not documented, the question is do we need it, happy to revert and mark the return type as str, let me know your view

cmp0xff · 2025-12-18T22:24:11Z

pandas-stubs/core/arrays/timedeltas.pyi

-        skipna: bool = ...,
-    ): ...
-    def median(
+    def __init__(


I think __new__ is preferred over __init__. It is easier to understand the return types in __new__ than the typing hint of self in __init__.

Same as above

cmp0xff · 2025-12-18T22:25:42Z

pandas-stubs/core/arrays/timedeltas.pyi

+        freq: Frequency | None = None,
+        copy: bool = False,
+    ) -> None: ...
    __rmul__ = ...


This can also drop

Okay will drop, I wanted to keep it concise but happy to do more.

cmp0xff · 2025-12-18T22:29:14Z

pandas-stubs/core/arrays/string_.pyi


 class StringArray(PandasArray):
-    def __init__(self, values, copy: bool = ...) -> None: ...
-    def __arrow_array__(self, type=...): ...


We need to keep this one for pyarrow

Got it will revert

cmp0xff · 2025-12-18T22:30:53Z

pandas-stubs/core/arrays/string_.pyi

-    def __init__(self, values, copy: bool = ...) -> None: ...
-    def __arrow_array__(self, type=...): ...
-    def __setitem__(self, key, value) -> None: ...
-    def value_counts(self, dropna: bool = True): ...


I did not find this one in the base classes, should probably keep it

Okay will keep and add a test

cmp0xff · 2025-12-18T22:32:00Z

pandas-stubs/core/arrays/period.pyi

 class PeriodArray(DatetimeLikeArrayMixin, DatelikeOps):
    __array_priority__: int = ...
-    def __init__(self, values, freq=..., dtype=..., copy: bool = ...) -> None: ...
+    def __init__(


__new__ instead of __init__?

cmp0xff · 2025-12-18T22:32:26Z

pandas-stubs/core/arrays/period.pyi

-    def __init__(self, values, freq=..., dtype=..., copy: bool = ...) -> None: ...
+    def __init__(
+        self,
+        values: Series[PeriodDtype] | npt.NDArray[np.integer] | PeriodIndex,


cmp0xff · 2025-12-18T22:35:08Z

pandas-stubs/core/arrays/sparse/array.pyi

    Ellipsis = "..."

 class SparseArray(ExtensionArray, ExtensionOpsMixin):
    def __init__(


__new__ instead of __init__?

Not sure it makes a difference here since we have only one value.

cmp0xff · 2025-12-18T22:35:57Z

pandas-stubs/core/arrays/sparse/array.pyi

+        sparse_index: SparseIndex | None = None,
+        fill_value: Scalar | None = None,
+        kind: str = "integer",
+        dtype: np.dtype | SparseDtype | None = ...,


Need to distinguish >= 3.11 (np.dtype) and 3.10 (np.dtype[Any])

cmp0xff · 2025-12-18T22:39:23Z

pandas-stubs/core/arrays/sparse/array.pyi

-    @property
-    def sp_index(self): ...
-    @property
-    def sp_values(self): ...
-    @property
-    def dtype(self): ...
-    @property
-    def fill_value(self): ...
-    @fill_value.setter
-    def fill_value(self, value) -> None: ...


I think removing them might not be a good idea. They seem to be the core use case of SpareArray. We can raise issues in Pandas for the proper documentation.

…1318_defaults_p2

cmp0xff · 2025-12-19T14:15:23Z

pandas-stubs/core/arrays/masked.pyi

    @overload
    def __getitem__(self, item: SequenceIndexer) -> Self: ...
-    def __iter__(self): ...
-    def __invert__(self): ...


Not in ExtensionArray, keep

cmp0xff · 2025-12-19T14:15:36Z

pandas-stubs/core/arrays/masked.pyi

    def __array__(
        self, dtype: NpDtype | None = None, copy: bool | None = None
    ) -> np_1darray: ...
-    def __arrow_array__(self, type=...): ...


cmp0xff · 2025-12-19T14:18:24Z

pandas-stubs/core/arrays/masked.pyi

    @property
    def nbytes(self) -> int: ...
-    def copy(self): ...
-    def value_counts(self, dropna: bool = True): ...


cmp0xff · 2025-12-19T16:52:50Z

pandas-stubs/core/arrays/integer.pyi

+    if sys.version_info >= (3, 11):
+        def __init__(
+            self, values: AnyArrayLike, mask: np_1darray, copy: bool = ...
+        ) -> None: ...
+    else:
+        def __init__(
+            self, values: AnyArrayLike, mask: np.ndarray, copy: bool = ...
+        ) -> None: ...


self, values: AnyArrayLike, mask: np_ndarray, copy: bool = ... would do in all cases

cmp0xff · 2025-12-19T17:21:59Z

pandas-stubs/core/arrays/datetimes.pyi

-    def month_name(self, locale=...): ...
-    def day_name(self, locale=...): ...
+    ) -> Self: ...
+    def to_pydatetime(self) -> npt.NDArray[np.object_]: ...


maybe np_1darray_object, also in other cases here

cmp0xff · 2025-12-19T17:22:20Z

pandas-stubs/core/arrays/datetimes.pyi

    is_year_end = ...
    is_leap_year = ...
-    def to_julian_date(self): ...
+    def to_julian_date(self) -> npt.NDArray[np.float64]: ...


maybe np_1darray_float

loicdiridollou and others added 5 commits December 15, 2025 12:30

GH1317 Add more defaults

3028115

GH1317 Add more defaults

77ddea8

GH1317 Add more defaults

6d78fd5

Apply suggestions from code review

95812e1

Co-authored-by: Yi-Fan Wang <[email protected]>

Drop ANN exceptions from *arrays* and core/base.py

0d592ce

loicdiridollou marked this pull request as draft December 18, 2025 19:09

loicdiridollou added 2 commits December 18, 2025 14:10

Merge branch 'main' into gh1318_defaults_p2

3db3e22

Fix issues

51d4e03

loicdiridollou marked this pull request as ready for review December 18, 2025 19:16

loicdiridollou added 4 commits December 18, 2025 14:20

Fix issues

c9e5a3e

Fix issues

ef42649

Fix issues

7c7c9cc

Fix issues

ac0a84c

loicdiridollou requested a review from cmp0xff December 18, 2025 19:48

cmp0xff reviewed Dec 18, 2025

View reviewed changes

loicdiridollou added 2 commits December 19, 2025 11:32

Merge branch 'main' of github.com:loicdiridollou/pandas-stubs into gh…

2526813

…1318_defaults_p2

GH1318 PR Feedback

33740e3

cmp0xff reviewed Dec 19, 2025

View reviewed changes

GH1317 PR Feedback

6b116b3

loicdiridollou requested a review from cmp0xff December 19, 2025 20:20

	values: Series[PeriodDtype] \| npt.NDArray[np.integer] \| PeriodIndex,
	values: np_ndarray_anyint \| PeriodArray \| PeriodIndex \| Series[Period],

Uh oh!

Drop ANN exceptions from *arrays* and core/base.py #1568

Are you sure you want to change the base?

Drop ANN exceptions from *arrays* and core/base.py #1568

Conversation

loicdiridollou commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmp0xff left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Drop ANN exceptions from arrays and core/base.py #1568

Drop ANN exceptions from arrays and core/base.py #1568

loicdiridollou commented Dec 18, 2025 •

edited

Loading