Skip to content

GH1570 Fix nightly issue with None/NA/NaT set #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmp0xff merged 1 commit into from
Dec 19, 2025
+11 −8
Merged

GH1570 Fix nightly issue with None/NA/NaT set #1571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions tests/frame/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from pandas._typing import Scalar

from tests import (
PD_LTE_23,
TYPE_CHECKING_INVALID_USAGE,
check,
)
Expand Down Expand Up @@ -428,16 +429,18 @@ def test_frame_setitem_na() -> None:
df.at["a", "y"] = None
df.iat[0, 0] = None

df.loc[:, "x"] = [None, pd.NA, pd.NaT]
df.iloc[:, 0] = [None, pd.NA, pd.NaT]
if PD_LTE_23:
# TODO: pandas-dev/pandas#63420, this is failing on latest build, should work
df.loc[:, "x"] = [None, pd.NA, pd.NaT]
df.iloc[:, 0] = [None, pd.NA, pd.NaT]

# TODO: mypy bug, remove after python/mypy#20420 has been resolved
df.loc[:, ["x"]] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]
df.iloc[:, [0]] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]
# TODO: mypy bug, remove after python/mypy#20420 has been resolved
df.loc[:, ["x"]] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]
df.iloc[:, [0]] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]

# TODO: mypy bug, remove after python/mypy#20420 has been resolved
df.loc[:, iter(["x"])] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]
df.iloc[:, iter([0])] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]
# TODO: mypy bug, remove after python/mypy#20420 has been resolved
df.loc[:, iter(["x"])] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]
df.iloc[:, iter([0])] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index]


def test_loc_set() -> None:
Expand Down