Add filtering function names to QueryRange (metrics) #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalmatze
commented
May 10, 2023
metalmatze
commented
May 10, 2023
monicawoj
reviewed
May 15, 2023
Contributor
monicawoj
left a comment
monicawoj
left a comment
There was a problem hiding this comment.
Functionality wise looks good to me, but I think the styling/UX can be improved. As is, I'm not sure exactly whether the goal was to make the 'Filter by function' input directly next to the other query filter input or not. The styling seems a little off in terms of spacing and rounding of corners (rounded next to sharp).
Additionally, if the user expands the query filter input, the filter by function input seems out of place.
ui/packages/shared/profile/src/MetricsGraph/MetricsTooltip/index.tsx
Outdated
Show resolved
Hide resolved
Member
Author
|
Resizing the matcher textarea now also looks less broken. 😌
|
monicawoj
approved these changes
May 15, 2023
metalmatze
force-pushed
the
metrics-range
branch
from
d978611 to
3e95e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filterByFunction moves from just the flame graph up to the ProfileExplorer (the top bar where a query gets defined). The filter query is used not only by the flame graph but also by the QueryRange (metrics). We should make sure to test with table and call graph (or at least plan to use the same filters in the future too).
There are a few small TODOs left but I wanted to share:
NaNnsfor durationHere's what filtering for
rulesfor a Prometheus looks like for both CPU Sample and Memory In-Use Bytes: