Skip to content

Fix origin check in EPMB's manage extrinsic #10248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix origin check in EPMB's manage extrinsic #10248

wants to merge 6 commits into from
+486 −113

Conversation

@kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Nov 7, 2025

.. And

  • Break down Admin and Manager origins for easier configuration
  • update the corresponding weights
  • a few more tests
  • complete the manage test cases.

@kianenigma kianenigma requested a review from a team as a code owner November 7, 2025 17:11
@kianenigma kianenigma added A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch labels Nov 7, 2025
@kianenigma
Copy link
Contributor Author

kianenigma commented Nov 7, 2025

/cmd prdoc --bump major

Ank4n
Ank4n reviewed Nov 10, 2025
View reviewed changes
substrate/frame/election-provider-multi-block/src/lib.rs

/// A less privileged origin than [`Config::AdminOrigin`], that can manage some election
/// aspects, without critical power.
type ManagerOrigin: EnsureOrigin<Self::RuntimeOrigin>;
Copy link
Contributor

@Ank4n Ank4n Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected practical outcome of this for Polkadot? Will this be assigned to a different track than StakingAdmin or to a single account?

Copy link
Contributor Author

@kianenigma kianenigma Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that manager could be fellowship, and Admin can be StakingAdmin/Root

sigurpol
sigurpol reviewed Nov 10, 2025
View reviewed changes
sigurpol
sigurpol reviewed Nov 10, 2025
View reviewed changes
@paritytech-workflow-stopper
Copy link

paritytech-workflow-stopper bot commented Nov 10, 2025

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/19226700548
Failed job name: test-linux-stable-runtime-benchmarks

@kianenigma kianenigma mentioned this pull request Nov 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ank4n Ank4n Ank4n left review comments

@sigurpol sigurpol sigurpol approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

A4-backport-stable2509 Pull request must be backported to the stable2509 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kianenigma @sigurpol @Ank4n