PatchWork AutoFix #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
|
||
| def check_password(self, password: str): | ||
| return self.pwd_hash == md5(password.encode('utf-8')).hexdigest() | ||
| return self.pwd_hash == scrypt(password.encode('utf-8'), salt=b'salt', n=16384, r=8, p=1).hex() |
Check failure
Code scanning / SonarCloud
Password hashing functions should use an unpredictable salt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 8 issues.
Fix XSS vulnerability by sanitizing user-controlled data in 'innerHTML'
Sanitized the user-controlled data being assigned to 'innerHTML' to prevent XSS vulnerabilitiesFix vulnerability in debug log message
Replaced the dynamic string concatenation with a constant string in the console.log function to prevent potential format specifier injection vulnerability.Fix string concatenation vulnerability in console.log function
Replaced vulnerable string concatenation in console.log function with a constant value for the format string.Fix string concatenation vulnerability in console.log
Changed the console.log message to use string interpolation for better security by removing the string concatenation with a non-literal variable.Fix ReDoS vulnerability in class removal
Replaced dynamic RegExp creation with a hardcoded regex to prevent ReDoS vulnerability.Fix security vulnerabilities in Docker Compose file
- Added 'no_new_privileges: true' in the 'security_opt' for the 'redis' service to prevent privilege escalation via setuid or setgid binaries.Fix SQL injection vulnerability by using parameterized queries
Replaced string concatenation in the create method with parameterized query to prevent SQL injection vulnerability.Fix security vulnerability by replacing usage of MD5 with a secure password hashing function
Replaced MD5 with a secure password hashing function hashlib.scrypt