fix: bind setTimeout to globalThis in SupabaseBroadcastAdapter for browser compatibility #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76d65a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit 76d65a1
☁️ Nx Cloud last updated this comment at |
jumski
force-pushed
the
11-19-fix_settimeout_binding_in_client
branch
from
441c31b to
2e8d068
Compare
jumski
force-pushed
the
11-19-fix_settimeout_binding_in_client
branch
from
2e8d068 to
d391b09
Compare
jumski
force-pushed
the
11-19-fix_settimeout_binding_in_client
branch
from
d391b09 to
b7d08e1
Compare
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Contributor
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-402.pgflow.pages.dev 📝 Details:
_Last updated: _ |
jumski
force-pushed
the
11-19-fix_settimeout_binding_in_client
branch
from
b7d08e1 to
76d65a1
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix setTimeout context binding issue in SupabaseBroadcastAdapter
This PR fixes a browser compatibility issue in the
SupabaseBroadcastAdapterclass wheresetTimeoutwas losing its context binding when used in browser environments. The issue would cause an error:"'setTimeout' called on an object that does not implement interface Window".The fix:
setTimeoutto the global context usingsetTimeout.bind(globalThis)in the constructorThis issue only manifested in browser environments, not in Node.js, which explains why our existing tests didn't catch it. I've added a test that simulates the browser's strict context requirements for
setTimeout.The PR also includes a planning document for implementing browser-based testing to catch similar issues in the future.