Skip to content

chore: use pnpm prefix for JSR commands and simplify snapshot release #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jumski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use pnpm prefix for JSR commands and simplify snapshot release #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"build": "nx run-many --target=build --all",
"version": "pnpm changeset version && ./scripts/update-jsr-json-version.sh",
"validate:publish:npm": "pnpm nx run-many -t build --exclude=demo,website,example-flows && pnpm publish --dry-run --provenance --recursive --filter=!./pkgs/edge-worker",
"validate:publish:jsr": "cd ./pkgs/edge-worker && jsr publish --dry-run --allow-slow-types",
"validate:publish:jsr": "cd ./pkgs/edge-worker && pnpm jsr publish --dry-run --allow-slow-types",
"validate:publish": "pnpm run validate:publish:npm && pnpm run validate:publish:jsr",
"publish:npm": "pnpm nx run-many -t build --exclude=demo,website,example-flows && pnpm publish --provenance --recursive --filter=!./pkgs/edge-worker",
"publish:jsr": "cd ./pkgs/edge-worker && jsr publish --allow-slow-types",
"publish:jsr": "cd ./pkgs/edge-worker && pnpm jsr publish --allow-slow-types",
"changeset:tag": "pnpm changeset tag && git push --follow-tags",
"release": "git status && pnpm run validate:publish && pnpm run publish:npm && pnpm run publish:jsr && pnpm run changeset:tag"
},
Expand Down
6 changes: 2 additions & 4 deletions scripts/snapshot-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,9 @@ NPM_SUCCESS=false
JSR_SUCCESS=true # Default true (only set false if JSR package exists and fails)
JSR_PUBLISHED_VERSION="" # Track JSR version if published

# Publish to npm (token is read from NPM_TOKEN env var via .npmrc)
# GITHUB_ACTIONS=true skips changeset's npm profile check which fails with automation tokens
# Publish to npm (exclude edge-worker which goes to JSR only)
echo -e "${BOLD}Publishing to npm...${NC}"
if GITHUB_ACTIONS=true pnpm exec changeset publish --tag snapshot ; then
if pnpm publish --recursive --tag snapshot --no-git-checks --filter='!./pkgs/edge-worker' ; then
echo -e "${GREEN}✓ npm packages published${NC}"
NPM_SUCCESS=true
else
Expand All @@ -343,7 +342,6 @@ if [[ -f pkgs/edge-worker/jsr.json ]]; then
echo ""
echo -e "${BOLD}Publishing to JSR...${NC}"
JSR_PUBLISH_CMD="pnpm jsr publish --allow-slow-types --allow-dirty"
# Pass token explicitly if set (pnpm jsr may not inherit JSR_TOKEN properly)
if [[ -n "${JSR_TOKEN:-}" ]]; then
JSR_PUBLISH_CMD="$JSR_PUBLISH_CMD --token $JSR_TOKEN"
fi
Expand Down