pgsql: Don't allocate memory for default arguments #20757
Conversation
| zend_string *table_name; | ||
| zend_string *pg_delimiter = NULL; | ||
| char *pg_null_as = NULL; | ||
| char *pg_null_as = "\\\\N"; |
There was a problem hiding this comment.
Can't you mark this as const 🤔
| char *pg_null_as = "\\\\N"; | |
| const char *pg_null_as = "\\\\N"; |
Also, isn't there potentially an issue if the user defined value contains a nul byte?
There was a problem hiding this comment.
Can't you mark this as const 🤔
No, because the Z_PARAM_STRING API internally calls the zend_parse_arg_string helper that has char **dest.
Also, isn't there potentially an issue if the user defined value contains a nul byte?
Yes
|
looks good, no idea if you want to try gina's suggestion or leave it for another PR eventually. |
I'll leave it. The const thing requires zend api changes. The NUL issue should be fixed separately and we should do an audit of the entire extension and fix all such issues in one go |
sure I was only referring to the param change to path type. Fine then. |
3 participants
No description provided.