Add namespace shortcut for Rule class #539
Open
+167
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a convenience method that simplifies the common pattern of
selecting classes by namespace. This allows:
Rule::namespace('Acme')
instead of:
Rule::allClasses()->that(new ResideInOneOfTheseNamespaces('Acme'))
Supports multiple namespaces via variadic parameters.
Related to #491
Tests verify that the shortcut: - Works correctly to filter classes by namespace - Detects violations properly - Supports multiple namespaces - Produces equivalent results to the full syntax
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=========================================
Coverage 97.75% 97.75%
- Complexity 615 616 +1
=========================================
Files 80 80
Lines 1778 1780 +2
=========================================
+ Hits 1738 1740 +2
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add example showing the shortcut syntax in the introduction section, right after the standard rule example.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a convenience method that simplifies the common pattern of selecting classes by namespace. This allows:
Rule::namespace('Acme')
instead of:
Rule::allClasses()->that(new ResideInOneOfTheseNamespaces('Acme'))
Supports multiple namespaces via variadic parameters. Related to #491