-
Notifications
You must be signed in to change notification settings - Fork 6.1k
domain: release server id by revoke etcd session #64192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: AmoebaProtozoa <[email protected]>
|
Hi @AmoebaProtozoa. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64192 +/- ##
================================================
+ Coverage 72.6828% 75.5263% +2.8434%
================================================
Files 1858 1882 +24
Lines 502725 519170 +16445
================================================
+ Hits 365395 392110 +26715
+ Misses 115087 103621 -11466
- Partials 22243 23439 +1196
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[LGTM Timeline notifier]Timeline:
|
|
/assign @wjhuang2016 |
|
ptal @wjhuang2016 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: disksing, hawkingrei, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What problem does this PR solve?
Issue Number: close #64191
Problem Summary:
What changed and how does it work?
change the way server id was released. Instead of deleting the etcd key directly, which may leak empty lease, close the serverID session instead.
Check List
Tests
tiup playground --db.binpath ./bin/tidb-servertiup playground --pid xxxRelease note
Please refer to Release Notes Language Style Guide to write a quality release note.