forked from open-telemetry/opentelemetry-go-instrumentation
-
Notifications
You must be signed in to change notification settings - Fork 0
Add function argument/return value offsetgen support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ddelnano
wants to merge
33
commits into
pixie-io:main
Choose a base branch
from
ddelnano:ddelnano/add-func-argument-retval-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add function argument/return value offsetgen support #1
ddelnano
wants to merge
33
commits into
pixie-io:main
from
ddelnano:ddelnano/add-func-argument-retval-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pen-telemetry#2380) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…en-telemetry#2381) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lemetry#2385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…en-telemetry#2389) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…en-telemetry#2387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ible (open-telemetry#2386) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pen-telemetry#2391) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pen-telemetry#2390) * chore(deps): update module go.opentelemetry.io/proto/otlp to v1.7.0 * Run go mod tidy --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <[email protected]>
…en-telemetry#2392) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…metry#2395) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ible (open-telemetry#2393) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…e struct lookup works Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
…d offset generation. Get internal/pkg/structfield package tests passing Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
…iter struct Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
…elds Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
…e interface for process.DWARF struct Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
3b8ad24 to
1b8858d
Compare
Signed-off-by: Dom Del Nano <[email protected]>
2 tasks
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
added a commit
to pixie-io/pixie
that referenced
this pull request
Jul 9, 2025
… Uprobes (#2207) Summary: Add `GoOffsetLocator` that fulfills DwarfReader APIs. Use as shim for Go Uprobes Our current Go uprobe implementation relies on parsing DWARF information. This is memory intensive and is not ideal if end users want to keep the PEM's memory usage low (results in 100-150MB memory spikes). In order to support lower memory uprobes and to support Go binaries without DWARF, we can introduce a shim for the existing DwarfReader API that can read the offsets from a file (via openteletrmy-go-instrumentation generated offsets) or from the existing DWARF information. This PR introduces the `GoOffsetLocator` and tests that it functions properly while leaving the DWARF based tracing in place. The next set of changes will populate the offsets from pixie-io/opentelemetry-go-instrumentation#1 and provide configuration to choose the desired implementation: solely DWARF, solely static offsets or to use them in tandem. Relevant Issues: N/A Type of change: /kind feature Test Plan: Existing Go bpf trace tests should pass --------- Signed-off-by: Dom Del Nano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.