Skip to content

Please review this change #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Please review this change #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5382902
Added rails 3 engine
Jul 15, 2011
5075424
Replaced class_inheritable_hash with class_attribute for rails 3.2
garytaylor Apr 1, 2012
77afad0
Changed named_scope to simply scope for rails 3.2
garytaylor Apr 1, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/preferences.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require 'preferences/preference_definition'

require 'preferences/engine'
# Adds support for defining preferences on ActiveRecord models.
#
# == Saving preferences
Expand Down Expand Up @@ -152,16 +152,16 @@ module MacroMethods
# user.save! # => true
def preference(name, *args)
unless included_modules.include?(InstanceMethods)
class_inheritable_hash :preference_definitions
class_attribute :preference_definitions
self.preference_definitions = {}

has_many :stored_preferences, :as => :owner, :class_name => 'Preference'

after_save :update_preferences

# Named scopes
named_scope :with_preferences, lambda {|preferences| build_preference_scope(preferences)}
named_scope :without_preferences, lambda {|preferences| build_preference_scope(preferences, true)}
scope :with_preferences, lambda {|preferences| build_preference_scope(preferences)}
scope :without_preferences, lambda {|preferences| build_preference_scope(preferences, true)}

extend Preferences::ClassMethods
include Preferences::InstanceMethods
Expand Down
5 changes: 5 additions & 0 deletions lib/preferences/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module Preferences
class Engine < Rails::Engine

end
end