Fix for Issue: https://github.com/pnp/pnpcore/pull/1688 when try to deploy empty sections from XML-Template #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m XML-Template
|
I reverted "my fix" and got your code and it's working, the page opens in edit mode without the issue I reported. Thank you @czullu very much for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue with provisioning Empty sections from here pnp/pnpcore#1688 is on translation from XML back to PnP.Core. The EmptySections have been translated to CustomWebPart but they should not be added to Page-Model as we add EmptySections if we try to save Sections without webParts.
Other Solution would have been to create NewEmptySection() Methode to Page.cs in PnP.Core and then add a EmptySection-CanvasControl to Page-Model.
@PedroMordeP I was able to correctly provision your XML-Template with default PnP.Core and this fix in PnP.Framework