Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 9, 2025

🎯 Aim

Aligns the spo_list_remove Language Model Tool with established naming conventions ({verb}_{noun}) and adds support for recycling lists instead of permanent deletion.

📷 Result

No visual changes - this is a backend tool enhancement for the Language Model Tools.

✅ What was done

  • Renamed tool: spo_list_removeremove_spo_list

    • Updated registration in ChatTools.ts
    • Updated metadata in package.json
  • Added recycle parameter: Optional boolean (default: false) to send lists to recycle bin

    interface ISharePointListRemoveParameters {
        title: string;
        webUrl: string;
        recycle?: boolean;  // New parameter with default: false
    }
    • Always included in CLI command with nullish coalescing operator for default value
    • Response message reflects action taken (recycled vs. permanently removed)
  • Enhanced model description: Concise documentation covering:

    • Core functionality (permanent removal vs. recycling based on parameter)
    • Use cases (cleanup unused lists, remove test data, manage site content)
  • Applied review feedback:

    • Simplified modelDescription to be more concise
    • Updated recycle parameter description for clarity
    • Set default value for recycle to false instead of empty string
    • Refactored code to always include recycle parameter in command inputs

🔗 Related issue

Follows patterns from PR #596 / issue #586.

Fixes #592

Original prompt

This section details on the original issue you should resolve

<issue_title>💡 [Feature]: Update spo_list_remove Language Model Tool to Follow standards</issue_title>
<issue_description>### 🎯 Aim of the feature

Refactor the existing spo_list_remove Language Model Tool to align with updated naming conventions, improve model descriptions, and add additional list removal options for enhanced SharePoint list management capabilities.

Issues to address:

  • Rename the tool to remove_spo_list following the naming convention {verb}_{noun} as established in the codebase
  • Improve modelDescription:
    • What exactly does the tool do? - describe the specific functionality and capabilities
    • What kind of information does it return? - detail the expected response format
    • When should and shouldn't it be used? - provide clear use cases and scenarios to avoid
    • Describe important limitations or constraints of the tool - identify technical and permission limitations
  • Refactor ListRemove
    • Missing Properties: lets add support for the following options: recycle

Under the hood use: spo list remove

The issue #586 has been implemented and can be used as a reference to ensure consistency with the correct standards.

🤖 Agent info

  • create your feature branch with the implementation based on dev branch. This is a must
  • when opening a PR you MUST target dev branch
  • similar change was done in this commit 796856b. you must use it as refrence

🤔 Additional remarks or comments

<agent_instructions>don't forget your feature branch MUST be created based on dev branch and NOT main.
</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Refactor spo_list_remove tool to align with standards Refactor spo_list_remove to remove_spo_list following naming conventions and add recycle support Nov 9, 2025
Copilot AI requested a review from Adam-it November 9, 2025 20:58
Copilot finished work on behalf of Adam-it November 9, 2025 20:58
@Adam-it Adam-it marked this pull request as ready for review November 9, 2025 21:31
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Can you apply the changes I pointed out

@Adam-it Adam-it marked this pull request as draft November 14, 2025 23:21
Copy link
Contributor Author

Copilot AI commented Nov 14, 2025

@copilot Can you apply the changes I pointed out

All changes have been applied in commit ccb39b3.

Copilot AI requested a review from Adam-it November 14, 2025 23:28
Copilot finished work on behalf of Adam-it November 14, 2025 23:28
@Adam-it Adam-it marked this pull request as ready for review November 14, 2025 23:34
@Adam-it Adam-it force-pushed the copilot/refactor-spo-list-tool branch from ccb39b3 to 4764830 Compare November 14, 2025 23:34
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked locally and works properly

Image

@Adam-it
Copy link
Member

Adam-it commented Nov 20, 2025

@Adam-it Adam-it added the 🤚 on hold I need to wait for something else label Nov 20, 2025
@Adam-it Adam-it force-pushed the copilot/refactor-spo-list-tool branch from b009105 to 859b635 Compare November 21, 2025 00:27
@Adam-it Adam-it removed the 🤚 on hold I need to wait for something else label Nov 21, 2025
@Adam-it Adam-it changed the title Refactor spo_list_remove to remove_spo_list following naming conventions and add recycle support Refactors spo_list_remove LM tool. Closes #592 Nov 21, 2025
@Adam-it Adam-it merged commit c0fbf06 into dev Nov 21, 2025
4 checks passed
@Adam-it Adam-it deleted the copilot/refactor-spo-list-tool branch November 21, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💡 [Feature]: Update spo_list_remove Language Model Tool to Follow standards

2 participants