Skip to content

Fixes channel output naming. Closes #663 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saurabh7019 merged 2 commits into from
Dec 11, 2025
Merged

Fixes channel output naming. Closes #663 #665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d5ba0c
Fixes output channel name
Adam-it Dec 10, 2025
b8e8934
reusing existing Logger.channel
Saurabh7019 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { ChatTools } from './chat/tools/ChatTools';
import { SpfxAppCLIActions } from './services/actions/SpfxAppCLIActions';
import { IncreaseVersionActions } from './services/actions/IncreaseVersionActions';
import { scheduleFeedbackChecks } from '@grconrad/vscode-extension-feedback';
import { Logger } from './services/dataType/Logger';


const feedbackFormUrl = 'https://forms.office.com/e/ZTfqAissqt';
Expand Down Expand Up @@ -46,13 +47,13 @@ export async function activate(context: vscode.ExtensionContext) {

PnPWebview.register();

const channel = vscode.window.createOutputChannel('SPFx Toolkit Extension');
Logger.getInstance();

scheduleFeedbackChecks(
{
memento: context.globalState,
logFn: (text: string) => {
channel.appendLine(text);
Logger.channel?.appendLine(text);
}
},
{
Expand All @@ -72,7 +73,7 @@ export async function activate(context: vscode.ExtensionContext) {
).then((disposable: vscode.Disposable) => {
context.subscriptions.push(disposable);
}).catch((reason: any) => {
channel.appendLine(`Failed to schedule feedback checks: ${reason}`);
Logger.channel?.appendLine(`Failed to schedule feedback checks: ${reason}`);
});

workspace.findFiles(PROJECT_FILE, '**/node_modules/**').then(async (files) => {
Expand Down