fix: Do not use constructor.name to check object

[roll]

Other projects running into the same problem:

• Do not use constructor.name to check object node-fetch/node-fetch#667

---

• fixes Using constructor.name for dataType.variant seems not to be reliable #372
• adds type checking to yarn precommit
• fix failing tests

---

Not sure what is correct behaviour for these tests and why they fail now e.g.:

  ● series functions › 3 dtype: expected matches actual

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Object {
    -   "DataType": "Utf8",
    +   "DataType": "String",
      }

One test failing locally that is not related to the PR:

 FAIL  __tests__/dataframe.test.ts (6.276 s)
  ● additional › upsample


    Expected:
    >>shape: (7, 3)
    ┌────────────┬────────┬────────┐
    │ date       ┆ groups ┆ values │
    │ ---        ┆ ---    ┆ ---    │
    │ date       ┆ str    ┆ f64    │
    ╞════════════╪════════╪════════╡
    │ 2024-02-01 ┆ A      ┆ 0.0    │
    │ 2024-03-01 ┆ A      ┆ 0.0    │
    │ 2024-03-31 ┆ A      ┆ 0.0    │
    │ 2024-04-30 ┆ A      ┆ 2.0    │
    │ 2024-03-31 ┆ B      ┆ 1.0    │
    │ 2024-04-30 ┆ B      ┆ 1.0    │
    │ 2024-05-31 ┆ B      ┆ 3.0    │
    └────────────┴────────┴────────┘
    Received:
    >>shape: (6, 3)
    ┌────────────┬────────┬────────┐
    │ date       ┆ groups ┆ values │
    │ ---        ┆ ---    ┆ ---    │
    │ date       ┆ str    ┆ f64    │
    ╞════════════╪════════╪════════╡
    │ 2024-02-01 ┆ A      ┆ 0.0    │
    │ 2024-03-01 ┆ A      ┆ 0.0    │
    │ 2024-04-01 ┆ A      ┆ 0.0    │
    │ 2024-03-31 ┆ B      ┆ 1.0    │
    │ 2024-04-30 ┆ B      ┆ 1.0    │
    │ 2024-05-31 ┆ B      ┆ 3.0    │
    └────────────┴────────┴────────┘

[Bidek56]

Python Polars returns String for pl.Series(["foo"]).dtype

[Bidek56]

bun run test --findRelatedTests __tests__/dataframe.test.ts are passing on my laptop on this branch.

[Bidek56]

@roll fix or nix? Thx

[roll]

@Bidek56
Please take a look:

• I had to skip the upsample test as it fails for me both on main/pr (not sure how CI passes on Github)
• I change Utf8 to String in a few comparison tests as it seems a correct behaviour as per fix: Do not use constructor.name to check object #385 (comment)

[Bidek56]

@Bidek56 Please take a look:

• I had to skip the upsample test as it fails for me both on main/pr (not sure how CI passes on Github)
• I change Utf8 to String in a few comparison tests as it seems a correct behaviour as per fix: Do not use constructor.name to check object #385 (comment)

LGTM, Can you please not skip skip the upsample test? It passed for me locally and on CI. Thx

[roll]

Thanks @Bidek56, thanks for looking into it!

I enabled test I think I confused it last time it seems actually passed on CI initially