Update TruffleRuby URLs and dependencies #517
Conversation
eregon
force-pushed
the
update-truffleruby-urls-and-dependencies
branch
2 times, most recently
from
38a98a6 to
7b002c3
Compare
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Looks good, but we should add additional tests to test/truffleruby-tests/dependencies_tests.sh for when the truffleruby version is 33.x or greater in order to test when the openssl and libyaml dependencies are omitted. We could do that in this PR or in a separate PR/commit. Depends on how fast you want this merged.
|
Thanks for the review. It's not urgent, I'll add them in this PR. |
|
I noticed not all tests are run in CI: Line 12 in 204f5dd |
* FWIW `echo {,**/}*_test{,s}.sh` does not work in Bash
because it yields `*_tests.sh` which of course does not exist.
* `echo **/*_test{,s}.sh` is fine in ZSH but does not list all files in Bash.
…ince they are the same
eregon
force-pushed
the
update-truffleruby-urls-and-dependencies
branch
from
a34e1d4 to
a7c4011
Compare
* See https://github.com/truffleruby/truffleruby/blob/master/doc/user/installing-libssl.md and https://github.com/truffleruby/truffleruby/blob/master/doc/user/installing-libyaml.md * libxml2 is not needed since 20.0 so just drop that: postmodern#359 (comment) * Fix order of arguments to assertEquals in tests.
eregon
force-pushed
the
update-truffleruby-urls-and-dependencies
branch
from
a7c4011 to
1d0ac4b
Compare
|
All good and passing now. |
| # Same as truffleruby dependencies | ||
| source "${BASH_SOURCE[0]%/*}/../truffleruby/dependencies.sh" |
There was a problem hiding this comment.
Could also be a symlink, not sure what you prefer.
|
The ArchLinux and OpenSUSE failures are unrelated to this PR and preexisting. The same tests also fail on FreeBSD and additonally there truffleruby tests fail since BSD is not a supported platform for TruffleRuby. Could you take care of those by pushing extra commits to this PR? |
2 participants
See individual commits for details.
FYI there is also postmodern/ruby-versions@e80b1c1