fix: large datasets on android 12 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2024 15:51
…ragma temp_store command in test (covered by makeList change)
stevensJourney
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
Originally reported by an end user
On my side with 10k Todos I ran into an I/O error on Android 12 which has to do with the tmp dir not being available for some reason.
I originally had a fix with
which works on runtime and would require me to use react-native-fs to identify the cache directory.
Upon looking for other solutions we found this with is compile time and in-memory meaning we don't need to depend on rn-fs
Verify solution
User has confirmed that this solved their issue.
Extra
Related issues: https://github.com/margelo/react-native-quick-sqlite/pull/25