fix: skip overdepending check for packages without binaries #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue prefix-dev#1949 where rattler-build incorrectly warns about overdepending for packages that contain no linkable binaries. The overdepending check looks for unused library dependencies by checking which libraries the package's binaries link against. For packages without any binaries, this check is meaningless - there's nothing that could link to libraries. This prevents false positives when building packages with only run dependencies like pixi-build-api-version (version constraint packages). Fixes prefix-dev#1949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1949 where rattler-build incorrectly warns about overdepending for packages that contain no linkable binaries.
The overdepending check looks for unused library dependencies by checking which libraries the package's binaries link against. For packages without any binaries, this check is meaningless - there's nothing that could link to libraries.
This prevents false positives when building packages with only run dependencies like
pixi-build-api-version(version constraint packages).Fixes #1949
AI Disclosure
Claude Code Web wrote this.