Progress bug #3
Merged
Progress bug #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksmaus
approved these changes
Jan 23, 2025
aleksmaus
left a comment
aleksmaus
left a comment
There was a problem hiding this comment.
Left one question. Otherwise looks ok.
| _, err := r._readHeader() | ||
| n, err := r._readHeader() | ||
|
|
||
| r.srcPos += int64(n) |
There was a problem hiding this comment.
doing this before error check, is this correct?
Contributor
Author
There was a problem hiding this comment.
Yeah, in general supposed to accept bytes before processing error. From io.Reader
Callers should always process the n > 0 bytes returned before considering the error err. Doing so correctly handles I/O errors that happen after reading some bytes and also both of the allowed EOF behaviors.
In practice it won't matter in this case because the call will error out and the reader will be in an error state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offsets on the read progress callback were misaligned.